Twelfth Post!

[hoisinsauce]

POST NAMER TBC-- work harder, meme!

Welcome back, anyway! Chat fandom, media, creative things, weirdness from around the net, funny stuff, anything! Meme awaits!

(start a comment thread by replying to this post)

 

Comments

Re: Coding

[(Anonymous)]

Stuck reviewing a 36-file PR full of utter slop. Look at this shit.

class FruitConstants:
  """
  Constants for fruit ingestion.
  """
  APPLE_OUTPUT = 'apple_output'
  BANANA_OUTPUT = 'banana_output'
  CHERRY_OUTPUT = 'cherry_output'
  DURIAN_OUTPUT = 'durian_output'

class FruitIngester:
  """
  Gets output locations.
  """
  def getOutputLocations(basePath):
    outputs = {}
    outputs['apple_output'] = basePath + FruitConstants.APPLE_OUTPUT
    outputs['banana_output'] = basePath + FruitConstants.BANANA_OUTPUT
    outputs['cherry_output'] = basePath + FruitConstants.CHERRY_OUTPUT
    outputs['durian_output'] = basePath + FruitConstants.DURIAN_OUTPUT
    return outputs

And no, the FruitConstants are never used anywhere outside this method.

Re: Coding

[(Anonymous)]

There's another file that just contains this (well, this and twenty other constants that are also defined in another file). Why! Just why!

class FruitMetrics:
  """
  Increment a counter metric
  """
  def incrementMetric(metricTag, value):
    if metricTag in counters:
       counters[metricTag] += value
    else:
       counters[metricTag] = value

  """
  Increment a counter metric by 1
  """
  def incrementMetric(metricTag):
    incrementMetric(metricTag, 1)

Re: Coding

[(Anonymous)]

Was this codebase in the hands of a team where LoC was treated as a metric? I've seen this kind of shit before when companies have contracted work out, to try to offshore dev jobs, and they've gone for the cheapest possible contractors who 1) don't know how to code and 2) are encouraged to write as many LoC as possible. You get this kind of code + meaningless comments, because there's usually a clause in the contract saying they have to comment every method.

Re: Coding

[(Anonymous)]

And tbf, the other place you get this kind of code is me, when I am lazy. Well, no, not THIS bad and nonsensical, but looking at FruitIngester, I could see myself copy-pasting repeated lines in a stupid way if it was an early draft; I'd rather get code working and then make it Not Stupid, than work out how to abstract things when I'm tired. Though I'm also lazy, so in that situation FruitIngester wouldn't exist in the first place, because why tf does it exist.

Re: Coding

[(Anonymous)]

Ding ding ding! This PR has three authors, and one of them is a contractor from Cognizant.

Of the other two, one of them is also offshore, and the other is an AI enthusiast. One of the files in this PR is a Cursor prompt he accidentally checked in.

Re: Coding

[(Anonymous)]

How does this shit have THREE authors???

Re: Coding

[(Anonymous)]

Also I forgot to pass 'self' into any of those class methods, oops. Well, now you know that this wasn't originally written in Python. It's been a while.

Re: Coding

[(Anonymous)]

Did they vibe code this holy fuck

Re: Coding

[(Anonymous)]

Vibe coding can produce bad results but I don't think you'd see "if X: Y else Y" in code it produced. I agree it's probably an idiot trying to juice loc stats. I don't know what etiquette you have to follow but I would "just say no" to this nonsense.

Re: Coding

[(Anonymous)]

So, I ended up writing a 30-comment review that ended with a gentle reminder that other people will read and collaborate on this code, and that every additional line of code adds overhead for the next engineer.

And guess what our AI-obsessed engineer did? He replied with a thumbs-up and then added a new .cursor file with instructions using my exact wording. I am so tired.

Re: Coding

[(Anonymous)]

Also, the PR is now 6.7k lines long.

Re: Coding

[(Anonymous)]

I hope at least 5k is a short story, committed for flavour.

Re: Coding

[(Anonymous)]

aw fuck I didn't just accidentally ping someone to our den of iniquity and bad code right

Re: Coding

[(Anonymous)]

I think you probably have. Keeps life interesting! I considered pinging mods but I don't think it'll wipe the notification if they have one. Dw is pretty dead anyway, mind.

Re: Coding

[hoisinsauce]

Removed comment preceding this to reduce chance of it pinging some random, one day. Comment originally read:



Was told to my comments had been addressed and that this PR was, once again, ready for review.

The unnecessary methods I complained about have now been marked deprecated. No additional changes have been made. ✨ The code in this PR was deprecated before it was even merged, which I think is a new record.

Re: Coding

[(Anonymous)]

Sounds like you might have gotten away with it, dan xD

Re: Coding

[(Anonymous)]

Tell them that they can't jump straight to deprecated; they need to first include a deprecation warning for anyone using the project as it currently is, to give them time to adjust. 😈

Re: Coding - MODS

[(Anonymous)]

Hello hoisinsauce does this notify you

Re: Coding - MODS

[hoisinsauce]

It does not. May depend on user settings. No dreamwidth notification and no email notification. Can delete the comment in case this is a bug that gets fixed one day.

Re: Coding

[(Anonymous)]

Update from slop-reviewing dan: just got handed a 19-page tech spec that was 'generated heavily with Cursor.' Very nice of them to include this disclaimer. Now instead of thinking that their tech spec makes no sense, I can just think that they're stupid.

Re: Coding

[(Anonymous)]

We reckon someone at my partner's work is using AI to generate the messages that they post in slack. They keep replying with multi-paragraph messages that repeat keywords from previous messages in the channel and answer questions that weren't asked. We cannot figure out why they think this is an activity worth performing.

Re: Coding

[(Anonymous)]

There's a few people at my workplace who do this as well. They copy-paste the Markdown formatting from ChatGPT, but it doesn't work in Slack so there's just random **'s littered everywhere that they can't even be bothered to fix up.

Re: Coding

[(Anonymous)]

Me: When a client's data changes significantly, I would like it if we sent an email to the client's support team informing them of the change.

Tech Spec: You're absolutely right! It is vitally important for the client's support team to be informed of any changes to their data. Here's how we can accomplish this:

📨 Create a service that detects changes in client data and submits a email request.
📨 Build an API that will take in the name of a client and determine the correct recipients for the email.
📨 Design a service that uses the email recipient API and then sends emails to the appropriate recipients.
📨 Set up a state orchestration service that will move email requests between the NEW, RECIPIENTS_FOUND, EMAIL_SENT, and COMPLETED statuses.

It is also important to remain compliant with all standards. To do that, we must enable robust logging and metrics. I propose the following metrics, to be tracked on a dashboard:

📈 # of emails sent
📈 # of unique recipients
📈 % of emails that contain the letter Y

I estimate that building and testing this project will take at least 15-17 weeks.

Re: Coding

[(Anonymous)]

> 📈 % of emails that contain the letter Y

Now that's the kind of logging that every enterprise needs. Ship it!